Skip to content

Update to jsonschema's format-nongpl extra #1244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 28, 2025
Merged

Update to jsonschema's format-nongpl extra #1244

merged 12 commits into from
Mar 28, 2025

Conversation

CalebCourier
Copy link
Collaborator

@CalebCourier CalebCourier commented Mar 14, 2025

Addresses: #1243

TODO

@CalebCourier
Copy link
Collaborator Author

License checks failed appropriately because all of the NVIDIA driver licenses are Other/Proprietary. @zsimjee Can we have someone look into these licenses to determine if they should be added to the allow list?

@CalebCourier CalebCourier marked this pull request as ready for review March 28, 2025 15:21
@CalebCourier
Copy link
Collaborator Author

License checks failed appropriately because all of the NVIDIA driver licenses are Other/Proprietary. @zsimjee Can we have someone look into these licenses to determine if they should be added to the allow list?

Our approach is to only include the core dependencies of guardrails-ai in our checks. The reasoning behind this is any and all extras are for integrating with third parties. If a user is utilizing those integrations, their also consenting to the licenses of the third parties. Additionally, it would be more useful for the user to have their own license checks on the whole of their dependencies when considering third parties.

@CalebCourier CalebCourier requested review from zsimjee and dtam March 28, 2025 15:31
@dtam dtam merged commit d188bad into main Mar 28, 2025
16 checks passed
@dtam dtam deleted the jsonschema-nongpl-extra branch March 28, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants